Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DiagnosticTag support #362

Merged
merged 3 commits into from
Sep 5, 2019
Merged

Add DiagnosticTag support #362

merged 3 commits into from
Sep 5, 2019

Conversation

akaroml
Copy link
Contributor

@akaroml akaroml commented Sep 3, 2019

Signed-off-by: Rome Li [email protected]

@eclipse-lsp4j-bot
Copy link

Can one of the admins verify this patch?

@akaroml
Copy link
Contributor Author

akaroml commented Sep 3, 2019

ref: https://github.com/microsoft/vscode-languageserver-node/blob/082631da44d6799358602a4abebadbf4fc47859b/types/src/main.ts#L513

yaohaizh
yaohaizh reviewed Sep 4, 2019
View reviewed changes
Copy link
Contributor

@yaohaizh yaohaizh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor issues.

@akaroml akaroml mentioned this pull request Sep 4, 2019
Merged
@akaroml
Fix indentations
e15b21b 
Signed-off-by: Rome Li <[email protected]>
@akaroml
Copy link
Contributor Author

akaroml commented Sep 4, 2019

Fixed indentations

spoenemann
spoenemann reviewed Sep 4, 2019
View reviewed changes
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any plan to adopt this property in the LSP specification?

org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/DiagnosticTag.java Outdated Show resolved Hide resolved
@KamasamaK
Copy link
Contributor

@spoenemann Yes, in v3.15. See microsoft/language-server-protocol#500

@akaroml
Fix copyright typo
5bd791f 
Signed-off-by: Rome Li <[email protected]>
@spoenemann spoenemann merged commit 1db24f5 into eclipse-lsp4j:master Sep 5, 2019
@spoenemann
Copy link
Contributor

Thanks!

@akaroml akaroml deleted the diagnostic-tag branch September 6, 2019 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaohaizh yaohaizh yaohaizh left review comments

@spoenemann spoenemann spoenemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akaroml @eclipse-lsp4j-bot @KamasamaK @spoenemann @yaohaizh